Add size for each log file - #2
Open
rewiko wants to merge 2 commits into
Open
Conversation
Remove debug log Add size file Update size parameter FilePositionEntry adding logs update pos file function in memory add debug size log update file size from pos_file read Save size inside the file and keep it backward compatible Revert "Add log throttling per file" This reverts commit f5bb69b. Remove debug log
rewiko
force-pushed
the
add-size-of-each-log-file
branch
2 times, most recently
from
November 4, 2019 08:54
9321337 to
427ea1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
As part of #1, log throttling would be doable and that will throttle the log after X logs per second, logs will be delayed.
What this PR does / why we need it:
This PR will add the size of the log which can be exported by fluent-plugin-prometheus-pr. We will be able to monitor the delay by comparing
fluentd_tail_file_positionandfluentd_tail_file_size.Docs Changes:
Release Note: